Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codeowner syntax for docs #584

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix codeowner syntax for docs #584

merged 1 commit into from
Nov 26, 2024

Conversation

samjwu
Copy link
Member

@samjwu samjwu commented Nov 9, 2024

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax

# The `docs/*` pattern will match files like
# `docs/getting-started.md` but not further nested files like
# `docs/build-app/troubleshooting.md`.
docs/*  [email protected]

@samjwu samjwu requested a review from alexxu-amd November 9, 2024 00:09
@samjwu samjwu self-assigned this Nov 9, 2024
NguyenNhuDi
NguyenNhuDi approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@NguyenNhuDi NguyenNhuDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@samjwu samjwu merged commit a0d96be into ROCm:develop Nov 26, 2024
7 of 8 checks passed
@samjwu samjwu deleted the codeowners branch November 26, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NguyenNhuDi NguyenNhuDi NguyenNhuDi approved these changes

@alexxu-amd alexxu-amd Awaiting requested review from alexxu-amd

@stanleytsang-amd stanleytsang-amd Awaiting requested review from stanleytsang-amd stanleytsang-amd is a code owner

@umfranzw umfranzw Awaiting requested review from umfranzw umfranzw is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

Assignees

@samjwu samjwu

Labels
ci:docs-only documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samjwu @NguyenNhuDi